Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

chore(samples): interactive tutorials code samples for import products#147

Merged
bcoe merged 2 commits intogoogleapis:mainfrom
nmykhailets:products-import
Mar 8, 2022
Merged

chore(samples): interactive tutorials code samples for import products#147
bcoe merged 2 commits intogoogleapis:mainfrom
nmykhailets:products-import

Conversation

@nmykhailets
Copy link
Copy Markdown
Contributor

@nmykhailets nmykhailets commented Feb 17, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@nmykhailets nmykhailets requested a review from a team February 17, 2022 16:44
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Feb 17, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added the api: retail Issues related to the googleapis/nodejs-retail API. label Feb 17, 2022
@nmykhailets nmykhailets changed the title Import products chore(samples): interactive tutorials code samples for import products Feb 17, 2022
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 18, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Feb 18, 2022

Warning: This pull request is touching the following templated files:

  • .kokoro/pre-samples-test.sh - .kokoro files are templated and should be updated in synthtool

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
kweinmeister
kweinmeister suggested changes Feb 21, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/product/import-products-big-query-table.js Outdated
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2022
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 23, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 23, 2022
chenlei1216
chenlei1216 approved these changes Feb 25, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/product/import-products-big-query-table.js Outdated
};

// The mode of reconciliation between existing products and the products to be imported.
const reconciliationMode = reconciliationModes.FULL;
Copy link
Copy Markdown
Contributor

@chenlei1216 chenlei1216 Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start with INCREMENTAL? FULL may take longer to finish and may delete products created by other samples.

Copy link
Copy Markdown
Contributor

@t-karasova t-karasova Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 1, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@bcoe bcoe added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2022
@bcoe bcoe merged commit 11dbdcf into googleapis:main Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@t-karasova t-karasova t-karasova left review comments

@bcoe bcoe bcoe approved these changes

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: retail Issues related to the googleapis/nodejs-retail API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nmykhailets @bcoe @chenlei1216 @kweinmeister @t-karasova @yoshi-kokoro @tetiana-karasova