Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

chore(samples): create/delete test resources scripts#145

Merged
bcoe merged 1 commit intogoogleapis:mainfrom
nmykhailets:test-setup
Feb 15, 2022
Merged

chore(samples): create/delete test resources scripts#145
bcoe merged 1 commit intogoogleapis:mainfrom
nmykhailets:test-setup

Conversation

@nmykhailets
Copy link
Copy Markdown
Contributor

@nmykhailets nmykhailets commented Feb 11, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@nmykhailets nmykhailets requested a review from a team February 11, 2022 11:00
@product-auto-label product-auto-label Bot added api: retail Issues related to the googleapis/nodejs-retail API. samples Issues that are directly related to samples. labels Feb 11, 2022
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2022
@t-karasova t-karasova mentioned this pull request Feb 14, 2022
Closed
4 tasks
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2022
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2022
bcoe
bcoe suggested changes Feb 14, 2022
View reviewed changes
Copy link
Copy Markdown

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to move the mocha config into a .json file, or .yaml file, so that it doesn't show up in the samples table of contents.

@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Feb 15, 2022

Warning: This pull request is touching the following templated files:

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2022
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2022
@bcoe bcoe merged commit cd39ca0 into googleapis:main Feb 15, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bcoe bcoe bcoe approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: retail Issues related to the googleapis/nodejs-retail API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmykhailets @bcoe @kweinmeister @yoshi-kokoro