Skip to content

fix(deps): update @grpc/grpc-js to ^0.6.6 #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcoe merged 1 commit into from
Oct 8, 2019
Merged

fix(deps): update @grpc/grpc-js to ^0.6.6 #772

bcoe merged 1 commit into from
Oct 8, 2019

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Oct 8, 2019 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #770 🦕

@callmehiphop callmehiphop requested a review from a team October 8, 2019 16:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

Merging #772 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #772   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          14       14           
  Lines         869      869           
  Branches      182      182           
=======================================
  Hits          841      841           
  Misses          7        7           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1294ce2...28fa6ec. Read the comment docs.

@bcoe bcoe merged commit 3c5199d into googleapis:master Oct 8, 2019
@bcoe bcoe mentioned this pull request Oct 15, 2019
Closed
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@fhinkel
chore: add dev dependencies for cloud-rad ref docs (googleapis#772)
3d046b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bcoe bcoe bcoe approved these changes

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DEADLINE_EXCEEDED makes application not receiving messages at all

4 participants

@callmehiphop @bcoe @stephenplusplus @googlebot