Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: rpcSpan closure logic in message-queues#2120

Closed
n3xt-alexy wants to merge 1 commit intogoogleapis:mainfrom
n3xt-alexy:patch-1
Closed

fix: rpcSpan closure logic in message-queues#2120
n3xt-alexy wants to merge 1 commit intogoogleapis:mainfrom
n3xt-alexy:patch-1

Conversation

@n3xt-alexy
Copy link
Copy Markdown

Ensure rpcSpan is closed only once after publish operation.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<2119> 🦕

Note: If you are opening a pull request against a legacy branch, PLEASE BE AWARE that we generally won't accept these except for things like important security fixes, and only for a limited time.

@n3xt-alexy n3xt-alexy requested a review from a team December 9, 2025 21:31
@n3xt-alexy n3xt-alexy requested a review from a team as a code owner December 9, 2025 21:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Dec 9, 2025
@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@n3xt-alexy n3xt-alexy changed the title Fix rpcSpan closure logic in message-queues fix: rpcSpan closure logic in message-queues Dec 9, 2025
@n3xt-alexy n3xt-alexy closed this by deleting the head repository Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants