Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

samples: some samples incorrectly called publishMessage without await#2035

Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom
publishmessage-await
May 8, 2025
Merged

samples: some samples incorrectly called publishMessage without await#2035
gcf-merge-on-green[bot] merged 2 commits intomainfrom
publishmessage-await

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented May 6, 2025

I just noticed this while doing something unrelated.

@feywind feywind requested a review from a team May 6, 2025 21:09
@feywind feywind requested a review from a team as a code owner May 6, 2025 21:09
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels May 6, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2025
@feywind feywind added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 66cc717 into main May 8, 2025
18 of 19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 8, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the publishmessage-await branch May 8, 2025 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants