This repository was archived by the owner on Mar 17, 2026. It is now read-only.
fix: set messaging.operation in createAttributes#2030
Merged
feywind merged 7 commits intogoogleapis:mainfrom May 9, 2025
Merged
fix: set messaging.operation in createAttributes#2030feywind merged 7 commits intogoogleapis:mainfrom
feywind merged 7 commits intogoogleapis:mainfrom
Conversation
feywind
approved these changes
May 9, 2025
hongalex
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an amendment to PR #2019 which resolved issue #2018. I did not add the
messaging.operationattribute to the correct place in the code; it is now set in a more logical spot:createAttributes. I also modified the tests to reflect this change.