This repository was archived by the owner on Mar 17, 2026. It is now read-only.
samples: topic publish() method is deprecated#1522
Merged
feywind merged 2 commits intogoogleapis:mainfrom Apr 26, 2022
labnol:patch-1
Merged
samples: topic publish() method is deprecated#1522feywind merged 2 commits intogoogleapis:mainfrom labnol:patch-1
feywind merged 2 commits intogoogleapis:mainfrom
labnol:patch-1
Conversation
The `publish()` method is deprecated in favor of `publishMessage()` and the latter requires an object.
Collaborator
|
@labnol Thanks for the PR! I'm still unclear if the publish() method is deprecated or just got marked deprecated in the docs by accident. I'll bring this up in the meeting later this week. |
feywind
approved these changes
Apr 26, 2022
Collaborator
feywind
left a comment
There was a problem hiding this comment.
We talked about this and decided to go ahead and merge this, but since there is a potential 2.0 API coming some time this year, we're not pushing super hard on cleaning this up everywhere.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish()method is deprecated in favor ofpublishMessage()and the latter requires an object.