Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

samples: topic publish() method is deprecated#1522

Merged
feywind merged 2 commits intogoogleapis:mainfrom
labnol:patch-1
Apr 26, 2022
Merged

samples: topic publish() method is deprecated#1522
feywind merged 2 commits intogoogleapis:mainfrom
labnol:patch-1

Conversation

@labnol
Copy link
Copy Markdown
Contributor

@labnol labnol commented Apr 15, 2022

The publish() method is deprecated in favor of publishMessage() and the latter requires an object.

The `publish()` method is deprecated in favor of `publishMessage()` and the latter requires an object.
@labnol labnol requested review from a team April 15, 2022 14:21
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 15, 2022
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Apr 19, 2022

@labnol Thanks for the PR! I'm still unclear if the publish() method is deprecated or just got marked deprecated in the docs by accident. I'll bring this up in the meeting later this week.

@feywind feywind added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2022
@feywind feywind removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 26, 2022
Copy link
Copy Markdown
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this and decided to go ahead and merge this, but since there is a potential 2.0 API coming some time this year, we're not pushing super hard on cleaning this up everywhere.

@feywind feywind changed the title Topic Publish method is deprecated samples: topic publish() method is deprecated Apr 26, 2022
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2022
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022
@feywind feywind merged commit 5ce58b1 into googleapis:main Apr 26, 2022
@labnol labnol deleted the patch-1 branch April 27, 2022 07:44
@labnol
Copy link
Copy Markdown
Contributor Author

labnol commented Apr 27, 2022

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants