Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: fix flaky schema and subscription tests#1518

Merged
feywind merged 5 commits intogoogleapis:mainfrom
feywind:flaky-tests
Apr 19, 2022
Merged

fix: fix flaky schema and subscription tests#1518
feywind merged 5 commits intogoogleapis:mainfrom
feywind:flaky-tests

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented Apr 13, 2022

Potential fixes:

#1498
#1516
#1468
#1327

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 13, 2022
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2022
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind
Copy link
Copy Markdown
Collaborator Author

feywind commented Apr 13, 2022

I'm going to run this through CI a few more times just to make sure it's not flaking now...

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind marked this pull request as ready for review April 13, 2022 19:04
@feywind feywind requested review from a team April 13, 2022 19:04
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@feywind feywind changed the title tests: fix flaky schema and subscription tests fix: fix flaky schema and subscription tests Apr 13, 2022
@feywind
Copy link
Copy Markdown
Collaborator Author

feywind commented Apr 13, 2022

I'm editing the type to fix to trigger another release, since apparently the last one failed?

@feywind
Copy link
Copy Markdown
Collaborator Author

feywind commented Apr 14, 2022

Mentioned in chat, but repeating here: if anyone reviews this and there aren't major issues, please go ahead and merge as well.

@feywind feywind merged commit 5ff0105 into googleapis:main Apr 19, 2022
@feywind feywind deleted the flaky-tests branch April 19, 2022 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants