This repository was archived by the owner on Mar 17, 2026. It is now read-only.
tests: fix another typing issue with streams#1491
Merged
feywind merged 4 commits intogoogleapis:mainfrom Feb 16, 2022
Merged
Conversation
product-auto-label
Bot
added
the
api: pubsub
feywind
added
owlbot:ignore
gcf-owl-bot
Bot
removed
the
owlbot:run
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Collaborator
Author
|
Unrelated: I'd kind of love to get some of these system tests running off the emulator... |
bcoe
suggested changes
Feb 16, 2022
| "scripts": { | ||
| "presystem-test": "npm run compile", | ||
| "system-test": "mocha build/system-test --timeout 600000", | ||
| "system-test": "GRPC_TRACE=all GRPC_VERBOSITY=DEBUG npx mocha build/system-test --timeout 600000", |
There was a problem hiding this comment.
the npx will cause the latest version of mocha from npm to always be used, which I"m slightly concerned with from a supply chain point of view.
What I might perhaps do instead is use cross-env, so that system-tests keep working on Windows, and drop the npx:
cross-env GRPC_TRACE=all GRPC_VERBOSITY=DEBUG mocha build/system-test --timeout=6000000
Collaborator
Author
There was a problem hiding this comment.
Yeah, sorry, I forgot to mention in chat that these particular diffs are just debug stuff I'll be removing. I'm trying to see if the DEADLINE_EXCEEDED error can be reproduced here.
feywind
added
do not merge
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
approved these changes
Feb 16, 2022
feywind
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either more typings changes happened, or I missed this one somehow.