Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

samples: update things referencing names to be namesOrIds#1488

Merged
feywind merged 2 commits intogoogleapis:mainfrom
feywind:gh1198-names-vs-ids
Feb 10, 2022
Merged

samples: update things referencing names to be namesOrIds#1488
feywind merged 2 commits intogoogleapis:mainfrom
feywind:gh1198-names-vs-ids

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented Feb 10, 2022

This is because the Node library lets you use either.

Fixes #1198 🦕

This is because the Node library lets you use either.
@feywind feywind requested review from a team February 10, 2022 00:10
@product-auto-label product-auto-label Bot added api: pubsub Issues related to the googleapis/nodejs-pubsub API. samples Issues that are directly related to samples. labels Feb 10, 2022
@feywind feywind added the owlbot:ignore instruct owl-bot to ignore a PR label Feb 10, 2022
@feywind
Copy link
Copy Markdown
Collaborator Author

feywind commented Feb 10, 2022

Adding owlbot:ignore due to the blocked other OwlBot PR.

Copy link
Copy Markdown
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating these in all samples!

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 10, 2022
@feywind feywind merged commit 506b3a5 into googleapis:main Feb 10, 2022
@feywind feywind deleted the gh1198-names-vs-ids branch February 10, 2022 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Samples: resource names and resource ID confusion

2 participants