Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

docs: fix publishMessage return type #1441

Merged
feywind merged 6 commits into from
Jan 21, 2022
Merged

docs: fix publishMessage return type #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71b7f84
docs: fix publishMessage return type
adi-hwn Dec 10, 2021
4b1d3db
Merge branch 'main' into main
adi-hwn Dec 9, 2021
6bad0c9
Merge branch 'main' into main
feywind Jan 20, 2022
5fed0dc
Merge branch 'main' into main
feywind Jan 20, 2022
0762ff7
Merge branch 'main' into main
meredithslota Jan 20, 2022
32627d9
Merge branch 'main' into main
feywind Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/topic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,12 +822,12 @@ export class Topic {
* const [messageId] = await topic.publishMessage({data});
* ```
*/
publishMessage(message: MessageOptions): Promise<[string]>;
publishMessage(message: MessageOptions): Promise<string>;
publishMessage(message: MessageOptions, callback: PublishCallback): void;
publishMessage(
message: MessageOptions,
callback?: PublishCallback
): Promise<[string]> | void {
): Promise<string> | void {
// Make a copy to ensure that any changes we make to it will not
// propagate up to the user's data.
message = Object.assign({}, message);
Expand Down
2 changes: 1 addition & 1 deletion system-test/pubsub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ describe('pubsub', () => {

function publish(messageCount: number) {
const data = Buffer.from('Hello, world!');
const promises: Array<Promise<[string]>> = [];
const promises: Array<Promise<string>> = [];

let id = 0;

Expand Down