Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

chore(cloud-rad): Add code fencing#1415

Merged
fhinkel merged 1 commit intomainfrom
fhinkel-rad-fencing
Nov 4, 2021
Merged

chore(cloud-rad): Add code fencing#1415
fhinkel merged 1 commit intomainfrom
fhinkel-rad-fencing

Conversation

@fhinkel
Copy link
Copy Markdown
Contributor

@fhinkel fhinkel commented Nov 3, 2021

Code examples need code fencing around them to distingish from
rich text for TSDoc.

Internally b/179483748

Script used:
https://github.com/fhinkel/cloud-rad-script/blob/main/fixExampleComments.js

Code examples need code fencing around them to distingish from
rich text for TSDoc.

Internally b/179483748

Script used:
https://github.com/fhinkel/cloud-rad-script/blob/main/fixExampleComments.js
@fhinkel fhinkel requested review from a team November 3, 2021 00:22
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Nov 3, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
Copy link
Copy Markdown
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Is it at all meaningful to try to specify a language on the fences?

@fhinkel
Copy link
Copy Markdown
Contributor Author

fhinkel commented Nov 4, 2021

It's legal in TSDoc, not sure it'll make it all the way into Devsite. But it shouldn't be necessary.

@fhinkel fhinkel merged commit ef2ec51 into main Nov 4, 2021
@fhinkel fhinkel deleted the fhinkel-rad-fencing branch November 4, 2021 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants