This repository was archived by the owner on Mar 17, 2026. It is now read-only.
tests: rewrite topic tests to use completely separate topic/sub pairs to avoid flakes#1397
Merged
feywind merged 1 commit intogoogleapis:mainfrom Sep 23, 2021
Merged
Conversation
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
anguillanneuf
approved these changes
Sep 22, 2021
Contributor
anguillanneuf
left a comment
anguillanneuf
left a comment
There was a problem hiding this comment.
I saw @hannahrogers-google apply a similar fix. Thanks for doing this!
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1392, #1395
Topic tests were starting to flake because the newer tests left sloppy remains, and the older tests weren't properly separate.