Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: temporarily pin sinon at 10.0.0#1252

Merged
feywind merged 2 commits intogoogleapis:masterfrom
feywind:pin-sinon-10-temp
Apr 9, 2021
Merged

fix: temporarily pin sinon at 10.0.0#1252
feywind merged 2 commits intogoogleapis:masterfrom
feywind:pin-sinon-10-temp

Conversation

@feywind
Copy link
Copy Markdown
Collaborator

@feywind feywind commented Apr 9, 2021

This is to fix some TypeScript compilation errors that are holding up a bunch of PRs in this repo. This will be reverted once upstream is fixed.

sinonjs/sinon#2352

@feywind feywind requested review from a team April 9, 2021 21:09
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Apr 9, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2021

Codecov Report

Merging #1252 (2d6f82c) into master (9697ab2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          26       26           
  Lines       12642    12642           
  Branches      611      562   -49     
=======================================
  Hits        12364    12364           
  Misses        273      273           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9697ab2...2d6f82c. Read the comment docs.

@feywind feywind merged commit 0922164 into googleapis:master Apr 9, 2021
@feywind feywind mentioned this pull request Apr 9, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request Apr 15, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.11.0](https://www.github.com/googleapis/nodejs-pubsub/compare/v2.10.0...v2.11.0) (2021-04-14)


### ⚠ BREAKING CHANGES

* fix: added support for Opentelemetry 0.18 - makes significant changes to OpenTelemetry support in order to unblock its usage again; the main user-visible change is that you will need to use 0.18+ versions of OpenTelemetry, and different items are passed to the server in spans.

### Bug Fixes

* added support for Opentelemetry 0.18 ([#1234](https://www.github.com/googleapis/nodejs-pubsub/issues/1234)) ([aedc36c](https://www.github.com/googleapis/nodejs-pubsub/commit/aedc36c3f8736eff1cb781b9e05457463481b3d6))
* follow-on proto updates from the removal of the common protos ([#1229](https://www.github.com/googleapis/nodejs-pubsub/issues/1229)) ([cb627d5](https://www.github.com/googleapis/nodejs-pubsub/commit/cb627d5555c617eb025181c9f9aaf1d2c9621a86))
* prevent attempt to publish 0 messages ([#1218](https://www.github.com/googleapis/nodejs-pubsub/issues/1218)) ([96e6535](https://www.github.com/googleapis/nodejs-pubsub/commit/96e653514b35d61f74ba2d5d6fa96e19bc45bf8c))
* remove common protos ([#1232](https://www.github.com/googleapis/nodejs-pubsub/issues/1232)) ([8838288](https://www.github.com/googleapis/nodejs-pubsub/commit/883828800c94f7ea21c8306d272b70b4576c664c))
* reverting the major from the OpenTelemetry change (it was already broken) ([#1257](https://www.github.com/googleapis/nodejs-pubsub/issues/1257)) ([09c428a](https://www.github.com/googleapis/nodejs-pubsub/commit/09c428a17eb20fcd0fc45301addb48d2bebc56a3))
* temporarily pin sinon at 10.0.0 ([#1252](https://www.github.com/googleapis/nodejs-pubsub/issues/1252)) ([0922164](https://www.github.com/googleapis/nodejs-pubsub/commit/09221643be0693463ed4e5d56efd0f1ebfbe78b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants