Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

docs: include allowExcessMessages in docs example#1245

Merged
feywind merged 2 commits intogoogleapis:masterfrom
lujstn:patch-1
Apr 14, 2021
Merged

docs: include allowExcessMessages in docs example#1245
feywind merged 2 commits intogoogleapis:masterfrom
lujstn:patch-1

Conversation

@lujstn
Copy link
Copy Markdown

@lujstn lujstn commented Mar 30, 2021

Docs fix as per #784 🦕

@lujstn lujstn requested review from a team March 30, 2021 22:58
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Mar 30, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 30, 2021
@lujstn
Copy link
Copy Markdown
Author

lujstn commented Mar 30, 2021

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 30, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2021

Codecov Report

Merging #1245 (37be411) into master (0922164) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          26       26           
  Lines       12642    12642           
  Branches      562      611   +49     
=======================================
  Hits        12364    12364           
  Misses        273      273           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0922164...37be411. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we intended to do this and just didn't. Thanks for the PR!

@feywind feywind changed the title Include allowExcessMessages in docs example docs: include allowExcessMessages in docs example Apr 14, 2021
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@feywind feywind merged commit e85b34c into googleapis:master Apr 14, 2021
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
…oogleapis#1245)

* Change config so test runner can work with proxy

We adjust this to allow the test proxy to use new changes in the test runner.

* Add the new proto for communicating with the proxy

We add a new proto and make adjustments to the test proxy to use the new proto. This change should enable us to work with the test runner properly.

* Remove the v2 test proxy

Remove the v2 test proxy because it is not used anymore. If we need it again we can just search for it in version control.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants