Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: update from shared protos, part deux!#1230

Closed
yoshi-automation wants to merge 3 commits intomasterfrom
autosynth-googleapis
Closed

fix: update from shared protos, part deux!#1230
yoshi-automation wants to merge 3 commits intomasterfrom
autosynth-googleapis

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Mar 17, 2021

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/b2e473bb-8cb9-437a-99a7-b397eb8b7938/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 361273630
Source-Link: googleapis/googleapis@5477122

@yoshi-automation
changes without context
bbff788 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation
build: update gapic-generator-typescript to v1.2.10.
bc3b2eb 
This update unblocks generating IAM v1 and several more libraries that were previously blocked by their package names.
Committer: @alexander-fenster
PiperOrigin-RevId: 361273630

Source-Author: Google APIs <[email protected]>
Source-Date: Fri Mar 5 20:02:38 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 5477122b3e8037a1dc5bc920536158edbd151dc4
Source-Link: googleapis/googleapis@5477122
@yoshi-automation yoshi-automation requested review from a team March 17, 2021 08:15
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Mar 17, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2021 •
edited
Loading

Codecov Report

Merging #1230 (bc3b2eb) into master (b954fd9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
- Coverage   97.79%   97.77%   -0.02%     
==========================================
  Files          26       26              
  Lines       12607    12607              
  Branches      562      592      +30     
==========================================
- Hits        12329    12327       -2     
- Misses        273      275       +2     
  Partials        5        5
Impacted Files Coverage Δ
src/message-stream.ts 98.21% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b954fd9...bc3b2eb. Read the comment docs.

@alexander-fenster alexander-fenster mentioned this pull request Mar 17, 2021
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 17, 2021
@alexander-fenster
fix: remove common protos (#1232)
8838288 
Common protos do not belong here, they are a part of google-gax.
Should undo the changes that autosynth is trying to make in #1229 and #1230.
@feywind feywind changed the title [CHANGE ME] Re-generated to pick up changes from googleapis. fix: update from shared protos, part deux! Mar 19, 2021
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Mar 19, 2021

This needs to wait for #1229

@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Mar 19, 2021

StatusError: Getting metadata from plugin failed with error: Deadline is too far in the future

Not sure what to think of that, I guess I'll retry the tests.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2021
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Mar 19, 2021

Okay, I get it... for some reason, the timeouts were removed from the protos, and grpc doesn't like that.

@alexander-fenster Any idea what went wrong here? I'm assuming this has to do with the recent changes to shared protos.

@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Mar 24, 2021

There was actually a problem with this one, and it looks like synthtool isn't going to update it, so I'm closing it out.

@feywind feywind closed this Mar 24, 2021
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@danieljbruce
chore(testproxy): read row should return a single row (googleapis#1230)
1ccbfe6 
* Slight change in data returned by readRow

* Empty-Commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement. context: partial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @feywind @yoshi-kokoro