Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: follow-on proto updates from the removal of the common protos#1229

Merged
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
autosynth-self
Mar 19, 2021
Merged

fix: follow-on proto updates from the removal of the common protos#1229
gcf-merge-on-green[bot] merged 3 commits intomasterfrom
autosynth-self

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Mar 17, 2021

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/b2e473bb-8cb9-437a-99a7-b397eb8b7938/targets

  • To automatically regenerate this PR, check this box.

@yoshi-automation
changes without context
5ca6cfc 
        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation yoshi-automation requested review from a team March 17, 2021 08:04
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Mar 17, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2021 •
edited
Loading

Codecov Report

Merging #1229 (a71eeeb) into master (77be4b3) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   97.78%   97.70%   -0.08%     
==========================================
  Files          26       26              
  Lines       12642    12642              
  Branches      592      585       -7     
==========================================
- Hits        12362    12352      -10     
- Misses        275      285      +10     
  Partials        5        5
Impacted Files Coverage Δ
src/subscriber.ts 97.38% <0.00%> (-1.50%) ⬇️
src/message-stream.ts 97.70% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77be4b3...a71eeeb. Read the comment docs.

@alexander-fenster alexander-fenster mentioned this pull request Mar 17, 2021
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 17, 2021
@alexander-fenster
fix: remove common protos (#1232)
8838288 
Common protos do not belong here, they are a part of google-gax.
Should undo the changes that autosynth is trying to make in #1229 and #1230.
@feywind feywind changed the title [CHANGE ME] Re-generated to pick up changes from self. fix: follow-on proto updates from the removal of the common protos Mar 19, 2021
feywind
feywind approved these changes Mar 19, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked this over with Alex, these should be fine.

@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Mar 19, 2021
@feywind feywind mentioned this pull request Mar 19, 2021
Closed
1 task
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 19, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit cb627d5 into master Mar 19, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the autosynth-self branch March 19, 2021 19:00
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request Apr 15, 2021
@release-please
chore: release 2.11.0 (#1258)
ee21ee6 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.11.0](https://www.github.com/googleapis/nodejs-pubsub/compare/v2.10.0...v2.11.0) (2021-04-14)


### ⚠ BREAKING CHANGES

* fix: added support for Opentelemetry 0.18 - makes significant changes to OpenTelemetry support in order to unblock its usage again; the main user-visible change is that you will need to use 0.18+ versions of OpenTelemetry, and different items are passed to the server in spans.

### Bug Fixes

* added support for Opentelemetry 0.18 ([#1234](https://www.github.com/googleapis/nodejs-pubsub/issues/1234)) ([aedc36c](https://www.github.com/googleapis/nodejs-pubsub/commit/aedc36c3f8736eff1cb781b9e05457463481b3d6))
* follow-on proto updates from the removal of the common protos ([#1229](https://www.github.com/googleapis/nodejs-pubsub/issues/1229)) ([cb627d5](https://www.github.com/googleapis/nodejs-pubsub/commit/cb627d5555c617eb025181c9f9aaf1d2c9621a86))
* prevent attempt to publish 0 messages ([#1218](https://www.github.com/googleapis/nodejs-pubsub/issues/1218)) ([96e6535](https://www.github.com/googleapis/nodejs-pubsub/commit/96e653514b35d61f74ba2d5d6fa96e19bc45bf8c))
* remove common protos ([#1232](https://www.github.com/googleapis/nodejs-pubsub/issues/1232)) ([8838288](https://www.github.com/googleapis/nodejs-pubsub/commit/883828800c94f7ea21c8306d272b70b4576c664c))
* reverting the major from the OpenTelemetry change (it was already broken) ([#1257](https://www.github.com/googleapis/nodejs-pubsub/issues/1257)) ([09c428a](https://www.github.com/googleapis/nodejs-pubsub/commit/09c428a17eb20fcd0fc45301addb48d2bebc56a3))
* temporarily pin sinon at 10.0.0 ([#1252](https://www.github.com/googleapis/nodejs-pubsub/issues/1252)) ([0922164](https://www.github.com/googleapis/nodejs-pubsub/commit/09221643be0693463ed4e5d56efd0f1ebfbe78b7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@feywind feywind feywind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit cla: yes This human has signed the Contributor License Agreement. context: none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @feywind @yoshi-kokoro