Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

feat: export PublishError#1216

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
pkuczynski:patch-1
Feb 22, 2021
Merged

feat: export PublishError#1216
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:masterfrom
pkuczynski:patch-1

Conversation

@pkuczynski
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1215

@pkuczynski pkuczynski requested review from a team February 21, 2021 12:10
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Feb 21, 2021
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2021

Codecov Report

Merging #1216 (ec78166) into master (dab72ce) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files          26       26           
  Lines       12601    12602    +1     
  Branches      559      608   +49     
=======================================
+ Hits        12323    12324    +1     
  Misses        273      273           
  Partials        5        5           
Impacted Files Coverage Δ
src/index.ts 96.20% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab72ce...ec78166. Read the comment docs.

@pkuczynski
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 21, 2021
@pkuczynski pkuczynski changed the title Export PublishError feat: export PublishError Feb 21, 2021
@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2021
@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Feb 22, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 7c75d70 into googleapis:master Feb 22, 2021
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 22, 2021
@pkuczynski pkuczynski deleted the patch-1 branch February 22, 2021 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose PublishError

3 participants