Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix: do not modify options object, use defaultScopes#1148

Merged
alexander-fenster merged 3 commits intomasterfrom
ggt-1.2.1
Nov 19, 2020
Merged

fix: do not modify options object, use defaultScopes#1148
alexander-fenster merged 3 commits intomasterfrom
ggt-1.2.1

Conversation

@alexander-fenster
Copy link
Copy Markdown
Contributor

@alexander-fenster alexander-fenster commented Nov 6, 2020

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@alexander-fenster alexander-fenster requested review from a team and bcoe November 6, 2020 22:29
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Nov 6, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #1148 (ab98b81) into master (3d6db84) will increase coverage by 0.00%.
The diff coverage is 98.10%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          25       25           
  Lines       11077    11171   +94     
  Branches      513      555   +42     
=======================================
+ Hits        10835    10927   +92     
- Misses        238      240    +2     
  Partials        4        4
Impacted Files Coverage Δ
src/v1/publisher_client.ts 97.73% <98.01%> (-0.02%) ⬇️
src/v1/subscriber_client.ts 98.21% <98.19%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6db84...ab98b81. Read the comment docs.

@alexander-fenster
Copy link
Copy Markdown
Contributor Author

alexander-fenster commented Nov 6, 2020

@feywind Have you seen these new failures on Node 14 and 15? I bet they might be related to some changes with streams, the events sometimes come in a different order. @bcoe and I had similar failures on other libraries. Will you be able to take a look at this? Let me know if you need my help here!

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Nov 7, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Nov 7, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Nov 7, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Nov 7, 2020

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 7, 2020
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Nov 15, 2020

@alexander-fenster Yeah, sorry, I have been out while moving. I'm checking out those failures in the context of the synthtool changes PR. Well, probably in this coming week, I'm just catching up on emails now.

@alexander-fenster
Copy link
Copy Markdown
Contributor Author

alexander-fenster commented Nov 19, 2020

@feywind Thank you, it looks good!

@alexander-fenster alexander-fenster merged commit 4745c10 into master Nov 19, 2020
@alexander-fenster alexander-fenster deleted the ggt-1.2.1 branch November 19, 2020 01:48
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (googleapis#1553)…
262d3d7 
… (googleapis#1148)

fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-fenster @feywind @bcoe