This repository was archived by the owner on Mar 17, 2026. It is now read-only.
feat: Enable server side flow control by default with the option to turn it off#1147
Merged
gcf-merge-on-green[bot] merged 6 commits intogoogleapis:masterfrom Nov 18, 2020
Merged
Conversation
…urn it off This change enables sending flow control settings automatically to the server. If flowControl.maxMessages > 0 or flowControl.maxBytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and SubscriberOptions.useLegacyFlowControl can be used for users who would like to opt-out of this feature in case they encounter issues with server side flow control.
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: pubsub
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 25 25
Lines 11066 11077 +11
Branches 557 561 +4
=======================================
+ Hits 10824 10835 +11
Misses 238 238
Partials 4 4
Continue to review full report at Codecov.
|
…urn it off This change enables sending flow control settings automatically to the server. If flowControl.maxMessages > 0 or flowControl.maxBytes > 0, flow control will be enforced at the server side (in addition to the client side). This behavior is enabled by default and SubscriberOptions.useLegacyFlowControl can be used for users who would like to opt-out of this feature in case they encounter issues with server side flow control.
feywind
approved these changes
Nov 15, 2020
Collaborator
feywind
left a comment
feywind
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This sort of touches on a conversation we've been having with the team about API surfaces having some backwards compatibility.
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
Hi, the tests seem to be pending for abnormally long time. Can we check if they are blocked? Thanks. |
stephenplusplus
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
feywind
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables sending flow control settings automatically to the server.
If flowControl.maxMessages > 0 or flowControl.maxBytes > 0, flow control will
be enforced at the server side (in addition to the client side).
This behavior is enabled by default and SubscriberOptions.useLegacyFlowControl can be used for users who would
like to opt-out of this feature in case they encounter issues with server side
flow control.