Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

docs: updated code of conduct (includes update to actions)#1142

Merged
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
autosynth-synthtool
Nov 18, 2020
Merged

docs: updated code of conduct (includes update to actions)#1142
gcf-merge-on-green[bot] merged 5 commits intomasterfrom
autosynth-synthtool

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/313ec1b8-2bb0-49a2-a59d-9211defb7a66/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@89c849b
Source-Link: googleapis/synthtool@a783321
Source-Link: googleapis/synthtool@b7413d3
Source-Link: googleapis/synthtool@5f6ef0e

Source-Author: Christopher Wilcox <[email protected]>
Source-Date: Thu Oct 22 14:22:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5f6ef0ec5501d33c4667885b37a7685a30d41a76
Source-Link: googleapis/synthtool@5f6ef0e
Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Thu Oct 22 22:32:52 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: b7413d38b763827c72c0360f0a3d286c84656eeb
Source-Link: googleapis/synthtool@b7413d3
Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Fri Oct 23 17:27:51 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: a783321fd55f010709294455584a553f4b24b944
Source-Link: googleapis/synthtool@a783321
Source-Author: Benjamin E. Coe <[email protected]>
Source-Date: Mon Oct 26 10:37:03 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 89c849ba5013e45e8fb688b138f33c2ec6083dc5
Source-Link: googleapis/synthtool@89c849b
@yoshi-automation yoshi-automation requested review from a team October 27, 2020 08:19
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2020

Codecov Report

Merging #1142 (0ba3b21) into master (a9c7e0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          25       25           
  Lines       11077    11077           
  Branches      561      513   -48     
=======================================
  Hits        10835    10835           
  Misses        238      238           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c7e0b...0ba3b21. Read the comment docs.

@bcoe bcoe changed the title [CHANGE ME] Re-generated to pick up changes from synthtool. docs: updated code of conduct (includes update to actions) Oct 27, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Oct 27, 2020
@JustinBeckwith JustinBeckwith added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Oct 27, 2020
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2020
@bcoe
Copy link
Copy Markdown

bcoe commented Oct 29, 2020

@feywind this looks like it's potentially an actual issue with Node@14/Node@15.

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Oct 31, 2020
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Nov 4, 2020

@bcoe will take a look!

@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Nov 15, 2020

I'm seeing this same error on my local Node 14. I have some catch-up to do, but I'll try to get it unblocked soonish.

@feywind feywind added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@feywind feywind added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 18, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2020
@feywind
Copy link
Copy Markdown
Collaborator

feywind commented Nov 18, 2020

In the immortal words of that place far, far away, I have a bad feeling about this. These tests are really too dependent on server timing and availability. I don't think this PR is causing the problem, though.

@gcf-merge-on-green gcf-merge-on-green Bot merged commit 3d6db84 into master Nov 18, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 18, 2020
@feywind feywind deleted the autosynth-synthtool branch November 18, 2020 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants