Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Default option maxExtensionMinutes is treated as seconds #1208

Closed
#1402
Closed
Default option maxExtensionMinutes is treated as seconds#1208
#1402
Assignees
feywind
Labels
🚨This issue needs some love.api: pubsubIssues related to the googleapis/nodejs-pubsub API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
@novemberborn

Description

@novemberborn
novemberborn
opened on Feb 9, 2021

The default options is set as 60 minutes:

nodejs-pubsub/src/default-options.ts

Lines 29 to 31 in ccebf72

// The maximum number of minutes that a message's lease will ever
// be extended.
maxExtensionMinutes: 60,

The value 60 is applied here:

nodejs-pubsub/src/lease-manager.ts

Line 188 in 74fc12e

maxExtension: defaultOptions.subscription.maxExtensionMinutes,

However maxExtension is documented as being a value in seconds, defaulting to 60:

nodejs-pubsub/src/lease-manager.ts

Lines 39 to 40 in 74fc12e

* @property {number} [maxExtension=60] The maximum duration (in seconds)
* to extend the message deadline before redelivering.

Arguably the default should be 1 and when that default is applied it needs to be modified by 60.

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: pubsubIssues related to the googleapis/nodejs-pubsub API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions