Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-pubsub
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.1.0
Choose a base ref
...
head repository: googleapis/nodejs-pubsub
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.2.0
Choose a head ref
  • 3 commits
  • 32 files changed
  • 5 contributors

Commits on Jul 22, 2025

  1. feat: ad-hoc, targeted debug logging (#2062)

    * feat: first set of logging changes
    
    * tests: add unit test for publisher queue logs
    
    * feat: more work on logging
    
    * feat: client-side subscriber flow control logs
    
    * chore: lint fix
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * feat: move all of the logs to sub-logs of pubsub
    
    * feat: disambiguate ack vs modack queue logs
    
    * fix: a few more log integration fixups
    
    * fix: clear up what 99th percentile means
    
    * fix: use the grpc constants instead of a number
    
    Co-authored-by: Alex Hong <[email protected]>
    
    * fix: tweak wording on 99th percentile log
    
    * fix: make the method signature changes extra-non-breaking
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: Alex Hong <[email protected]>
    3 people authored Jul 22, 2025
    Configuration menu
    Copy the full SHA
    dce83c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2025

  1. feat: add timeout option and graceful shutdown to Subscription.close() (

    #2068)
    
    * feat: Add timeout option to Subscription.close()
    
    Implements a new `timeout` option (using `Duration`) for the `Subscription.close()` method.
    
    This provides more control over the shutdown process:
    - If `timeout` is zero, the subscription closes as quickly as possible without nacking buffered messages.
    - If `timeout` is positive, the subscription attempts to nack any buffered messages (in the lease manager) and waits up to the specified duration for pending acknowledgements and nacks to be sent to the server.
    - If no timeout is provided, the behavior remains as before (waits indefinitely for pending acks/modacks, no nacking).
    
    The core logic is implemented in `Subscriber.close()`. `PubSub.close()` documentation is updated to clarify its scope and recommend using `Subscription.close()` directly for this feature.
    
    Includes:
    - Unit tests for the new timeout behavior in `Subscriber.close()`.
    - A TypeScript sample (`samples/closeSubscriptionWithTimeout.ts`) demonstrating usage.
    - Updated JSDoc documentation for relevant methods.
    
    * docs: revert README change so release-please can do it
    
    * feat: jules' vibin' is too lo-fi, fix some bad assumptions
    
    * samples: typeless a JS sample for close with timeout
    
    * feat: add awaitWithTimeout and test
    
    * tests: also test error results without timeout
    
    * feat: update for the current spec, test updates coming
    
    * tests: misc fixes before further additions
    
    * feat: update Temporal shims to match latest standards
    
    * chore: linter fix
    
    * feat: update to latest spec doc info, finish unit tests
    
    * feat: also move the options from close() parameters to subscriber options
    
    * chore: fix linter errors
    
    * samples: update to latest API changes
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    * fix: no need to check isEmpty on remove
    
    * chore: remove unneeded promise skip code
    
    * fix: substantially clarify the awaitWithTimeout interface
    
    * chore: hoist timeout logic into its own method
    
    * fix: tests were leaking EventEmitter handlers
    
    * chore: change constant to CONSTANT_CASE
    
    ---------
    
    Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    3 people authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    8dee024 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 5.2.0 (#2073)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Aug 7, 2025
    Configuration menu
    Copy the full SHA
    e546f2c View commit details
    Browse the repository at this point in the history
Loading