Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Commit 1e28405

Browse files
gcf-owl-bot[bot]gcf-owl-bot[bot]
authored
feat: Make INTERNAL a retryable error for Pull (#1681)
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 510255779 Source-Link: https://togithub.com/googleapis/googleapis/commit/58e4422ffda317bbbb03e30bb4620afa8ad1c7d6 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/d67c1eb9f045f342a1dbad6666af3c1331eae615 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDY3YzFlYjlmMDQ1ZjM0MmExZGJhZDY2NjZhZjNjMTMzMWVhZTYxNSJ9 BEGIN_NESTED_COMMIT feat: Add temporary_failed_ack_ids to ModifyAckDeadlineConfirmation PiperOrigin-RevId: 510255074 Source-Link: https://togithub.com/googleapis/googleapis/commit/7427d37520b0f9ccdcd1a5a83288cdeea43cf826 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c7d5aacbca6a81c35930abf219536447d0e58702 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzdkNWFhY2JjYTZhODFjMzU5MzBhYmYyMTk1MzY0NDdkMGU1ODcwMiJ9 END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: Clarify BigQueryConfig PERMISSION_DENIED state PiperOrigin-RevId: 509847316 Source-Link: https://togithub.com/googleapis/googleapis/commit/d753d6386b031aa031b53d7bb1c23a23a78ee615 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/da4e7fe0044b303303ef4c8e46efaf0fcc98e8bf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGE0ZTdmZTAwNDRiMzAzMzAzZWY0YzhlNDZlZmFmMGZjYzk4ZThiZiJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: Clarify subscription description PiperOrigin-RevId: 509847159 Source-Link: https://togithub.com/googleapis/googleapis/commit/2a1543a1c0e72f03a95a4be9f32e30fc4cedf879 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/a4996434dc7ede3eb40ee6098130520e7d8049a9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTQ5OTY0MzRkYzdlZGUzZWI0MGVlNjA5ODEzMDUyMGU3ZDgwNDlhOSJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: Replacing HTML code with Markdown docs: Fix PullResponse description docs: Fix Pull description PiperOrigin-RevId: 509846267 Source-Link: https://togithub.com/googleapis/googleapis/commit/bb626b17c39848285f7f69ed978c843a900cee56 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/34c8b57847276f7d67ced245b56075b9cde86094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRjOGI1Nzg0NzI3NmY3ZDY3Y2VkMjQ1YjU2MDc1YjljZGU4NjA5NCJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: Update Pub/Sub topic retention limit from 7 days to 31 days PiperOrigin-RevId: 509846179 Source-Link: https://togithub.com/googleapis/googleapis/commit/19473b44ae71bd853e30cfdc6cf0adb3818bc9c9 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/db895f1453c272f599f219dcacdd4f08c3f3bb6c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGI4OTVmMTQ1M2MyNzJmNTk5ZjIxOWRjYWNkZDRmMDhjM2YzYmI2YyJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITfeat: Add google.api.method.signature to update methods PiperOrigin-RevId: 509649352 Source-Link: https://togithub.com/googleapis/googleapis/commit/1870ba2163526fa9fba63bf899c92707476d4603 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/515dcdfdd27ff00c30e555bdf17b7743e21457e9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTE1ZGNkZmRkMjdmZjAwYzMwZTU1NWJkZjE3Yjc3NDNlMjE0NTdlOSJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: changing format of the jsdoc links PiperOrigin-RevId: 509352615 Source-Link: https://togithub.com/googleapis/googleapis/commit/b737d30dae27222d86fa340ecb99292df4585762 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/8efadf3d58780ea1c550268d46a3dc701ba37fcf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGVmYWRmM2Q1ODc4MGVhMWM1NTAyNjhkNDZhM2RjNzAxYmEzN2ZjZiJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITdocs: Mark revision_id in CommitSchemaRevisionRequest deprecated PiperOrigin-RevId: 508076213 Source-Link: https://togithub.com/googleapis/googleapis/commit/3b9ae88062e8f0f6603cc8bcba945197cc60d314 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/d5e26492de9100eb2cf686ea7bccf2498b6600d4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDVlMjY0OTJkZTkxMDBlYjJjZjY4NmVhN2JjY2YyNDk4YjY2MDBkNCJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITchore(gitignore): only ignore folders in the top level PiperOrigin-RevId: 507603203 Source-Link: https://togithub.com/googleapis/googleapis/commit/a4f2de456480c0a4ed9feeeaa1f8ee620bbef23a Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/dcf882154e7c710ecf2a1abc77b35c95f9062371 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGNmODgyMTU0ZTdjNzEwZWNmMmExYWJjNzdiMzVjOTVmOTA2MjM3MSJ9 END_NESTED_COMMITBEGIN_NESTED_COMMITchore: update .gitignore to always include protos folder Use gapic-generator-typescript v3.0.0. PiperOrigin-RevId: 507004755 Source-Link: https://togithub.com/googleapis/googleapis/commit/d784f3c1043616fc0646e9ce7afa1b9161cc02de Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/5e64ba8615f65fdedb1fcd6ac792e5ea621027e4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWU2NGJhODYxNWY2NWZkZWRiMWZjZDZhYzc5MmU1ZWE2MjEwMjdlNCJ9 END_NESTED_COMMIT
1 parent faa885f commit 1e28405

File tree

10 files changed

+277
-163
lines changed

10 files changed

+277
-163
lines changed

‎.gitignore‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
**/*.log
22
**/node_modules
3-
.coverage
4-
coverage
5-
.nyc_output
6-
docs/
7-
out/
8-
build/
3+
/.coverage
4+
/coverage
5+
/.nyc_output
6+
/docs/
7+
/out/
8+
/build/
99
system-test/secrets.js
1010
system-test/*key.json
1111
*.lock

‎protos/google/pubsub/v1/pubsub.proto‎

Lines changed: 42 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ service Publisher {
6060
patch: "/v1/{topic.name=projects/*/topics/*}"
6161
body: "*"
6262
};
63+
option (google.api.method_signature) = "topic,update_mask";
6364
}
6465

6566
// Adds one or more messages to the topic. Returns `NOT_FOUND` if the topic
@@ -214,7 +215,7 @@ message Topic {
214215
// timestamp](https://cloud.google.com/pubsub/docs/replay-overview#seek_to_a_time)
215216
// that is up to `message_retention_duration` in the past. If this field is
216217
// not set, message retention is controlled by settings on individual
217-
// subscriptions. Cannot be more than 7 days or less than 10 minutes.
218+
// subscriptions. Cannot be more than 31 days or less than 10 minutes.
218219
google.protobuf.Duration message_retention_duration = 8;
219220
}
220221

@@ -461,6 +462,7 @@ service Subscriber {
461462
patch: "/v1/{subscription.name=projects/*/subscriptions/*}"
462463
body: "*"
463464
};
465+
option (google.api.method_signature) = "subscription,update_mask";
464466
}
465467

466468
// Lists matching subscriptions.
@@ -515,9 +517,7 @@ service Subscriber {
515517
option (google.api.method_signature) = "subscription,ack_ids";
516518
}
517519

518-
// Pulls messages from the server. The server may return `UNAVAILABLE` if
519-
// there are too many concurrent pull requests pending for the given
520-
// subscription.
520+
// Pulls messages from the server.
521521
rpc Pull(PullRequest) returns (PullResponse) {
522522
option (google.api.http) = {
523523
post: "/v1/{subscription=projects/*/subscriptions/*}:pull"
@@ -554,10 +554,10 @@ service Subscriber {
554554
}
555555

556556
// Gets the configuration details of a snapshot. Snapshots are used in
557-
// <a href="https://cloud.google.com/pubsub/docs/replay-overview">Seek</a>
558-
// operations, which allow you to manage message acknowledgments in bulk. That
559-
// is, you can set the acknowledgment state of messages in an existing
560-
// subscription to the state captured by a snapshot.
557+
// [Seek](https://cloud.google.com/pubsub/docs/replay-overview) operations,
558+
// which allow you to manage message acknowledgments in bulk. That is, you can
559+
// set the acknowledgment state of messages in an existing subscription to the
560+
// state captured by a snapshot.
561561
rpc GetSnapshot(GetSnapshotRequest) returns (Snapshot) {
562562
option (google.api.http) = {
563563
get: "/v1/{snapshot=projects/*/snapshots/*}"
@@ -602,16 +602,16 @@ service Subscriber {
602602
}
603603

604604
// Updates an existing snapshot. Snapshots are used in
605-
// <a href="https://cloud.google.com/pubsub/docs/replay-overview">Seek</a>
606-
// operations, which allow
607-
// you to manage message acknowledgments in bulk. That is, you can set the
608-
// acknowledgment state of messages in an existing subscription to the state
609-
// captured by a snapshot.
605+
// [Seek](https://cloud.google.com/pubsub/docs/replay-overview) operations,
606+
// which allow you to manage message acknowledgments in bulk. That is, you can
607+
// set the acknowledgment state of messages in an existing subscription to the
608+
// state captured by a snapshot.
610609
rpc UpdateSnapshot(UpdateSnapshotRequest) returns (Snapshot) {
611610
option (google.api.http) = {
612611
patch: "/v1/{snapshot.name=projects/*/snapshots/*}"
613612
body: "*"
614613
};
614+
option (google.api.method_signature) = "snapshot,update_mask";
615615
}
616616

617617
// Removes an existing snapshot. Snapshots are used in [Seek]
@@ -645,7 +645,9 @@ service Subscriber {
645645
}
646646
}
647647

648-
// A subscription resource.
648+
// A subscription resource. If none of `push_config` or `bigquery_config` is
649+
// set, then the subscriber will pull and ack messages using API methods. At
650+
// most one of these fields may be set.
649651
message Subscription {
650652
option (google.api.resource) = {
651653
type: "pubsub.googleapis.com/Subscription"
@@ -683,21 +685,17 @@ message Subscription {
683685
];
684686

685687
// If push delivery is used with this subscription, this field is
686-
// used to configure it. Either `pushConfig` or `bigQueryConfig` can be set,
687-
// but not both. If both are empty, then the subscriber will pull and ack
688-
// messages using API methods.
688+
// used to configure it.
689689
PushConfig push_config = 4;
690690

691691
// If delivery to BigQuery is used with this subscription, this field is
692-
// used to configure it. Either `pushConfig` or `bigQueryConfig` can be set,
693-
// but not both. If both are empty, then the subscriber will pull and ack
694-
// messages using API methods.
692+
// used to configure it.
695693
BigQueryConfig bigquery_config = 18;
696694

697695
// The approximate amount of time (on a best-effort basis) Pub/Sub waits for
698696
// the subscriber to acknowledge receipt before resending the message. In the
699697
// interval after the message is delivered and before it is acknowledged, it
700-
// is considered to be <i>outstanding</i>. During that time period, the
698+
// is considered to be _outstanding_. During that time period, the
701699
// message will not be redelivered (on a best-effort basis).
702700
//
703701
// For pull subscriptions, this value is used as the initial value for the ack
@@ -732,8 +730,8 @@ message Subscription {
732730
// minutes.
733731
google.protobuf.Duration message_retention_duration = 8;
734732

735-
// See <a href="https://cloud.google.com/pubsub/docs/labels"> Creating and
736-
// managing labels</a>.
733+
// See [Creating and managing
734+
// labels](https://cloud.google.com/pubsub/docs/labels).
737735
map<string, string> labels = 9;
738736

739737
// If true, messages published with the same `ordering_key` in `PubsubMessage`
@@ -922,7 +920,7 @@ message PushConfig {
922920
// * `v1` or `v1beta2`: uses the push format defined in the v1 Pub/Sub API.
923921
//
924922
// For example:
925-
// <pre><code>attributes { "x-goog-version": "v1" } </code></pre>
923+
// `attributes { "x-goog-version": "v1" }`
926924
map<string, string> attributes = 2;
927925

928926
// An authentication method used by push endpoints to verify the source of
@@ -948,6 +946,11 @@ message BigQueryConfig {
948946
ACTIVE = 1;
949947

950948
// Cannot write to the BigQuery table because of permission denied errors.
949+
// This can happen if
950+
// - Pub/Sub SA has not been granted the [appropriate BigQuery IAM
951+
// permissions](https://cloud.google.com/pubsub/docs/create-subscription#assign_bigquery_service_account)
952+
// - bigquery.googleapis.com API is not enabled for the project
953+
// ([instructions](https://cloud.google.com/service-usage/docs/enable-disable))
951954
PERMISSION_DENIED = 2;
952955

953956
// Cannot write to the BigQuery table because it does not exist.
@@ -958,7 +961,7 @@ message BigQueryConfig {
958961
}
959962

960963
// The name of the table to which to write data, of the form
961-
// {projectId}:{datasetId}.{tableId}
964+
// {projectId}.{datasetId}.{tableId}
962965
string table = 1;
963966

964967
// When true, use the topic's schema as the columns to write to in BigQuery,
@@ -1127,7 +1130,8 @@ message PullRequest {
11271130
// Response for the `Pull` method.
11281131
message PullResponse {
11291132
// Received Pub/Sub messages. The list will be empty if there are no more
1130-
// messages available in the backlog. For JSON, the response can be entirely
1133+
// messages available in the backlog, or if no messages could be returned
1134+
// before the request timeout. For JSON, the response can be entirely
11311135
// empty. The Pub/Sub system may return fewer than the `maxMessages` requested
11321136
// even if there are more messages available in the backlog.
11331137
repeated ReceivedMessage received_messages = 1;
@@ -1270,6 +1274,9 @@ message StreamingPullResponse {
12701274

12711275
// List of acknowledgement IDs that were out of order.
12721276
repeated string unordered_ack_ids = 3;
1277+
1278+
// List of acknowledgement IDs that failed processing with temporary issues.
1279+
repeated string temporary_failed_ack_ids = 4;
12731280
}
12741281

12751282
// Acknowledgement IDs sent in one or more previous requests to modify the
@@ -1281,21 +1288,23 @@ message StreamingPullResponse {
12811288
// List of acknowledgement IDs that were malformed or whose acknowledgement
12821289
// deadline has expired.
12831290
repeated string invalid_ack_ids = 2;
1291+
1292+
// List of acknowledgement IDs that failed processing with temporary issues.
1293+
repeated string temporary_failed_ack_ids = 3;
12841294
}
12851295

12861296
// Subscription properties sent as part of the response.
12871297
message SubscriptionProperties {
12881298
// True iff exactly once delivery is enabled for this subscription.
12891299
bool exactly_once_delivery_enabled = 1;
1300+
12901301
// True iff message ordering is enabled for this subscription.
12911302
bool message_ordering_enabled = 2;
12921303
}
12931304

12941305
// Received Pub/Sub messages. This will not be empty.
12951306
repeated ReceivedMessage received_messages = 1;
12961307

1297-
reserved 2;
1298-
12991308
// This field will only be set if `enable_exactly_once_delivery` is set to
13001309
// `true`.
13011310
AcknowledgeConfirmation acknowledge_confirmation = 5;
@@ -1313,9 +1322,9 @@ message CreateSnapshotRequest {
13131322
// Required. User-provided name for this snapshot. If the name is not provided
13141323
// in the request, the server will assign a random name for this snapshot on
13151324
// the same project as the subscription. Note that for REST API requests, you
1316-
// must specify a name. See the <a
1317-
// href="https://cloud.google.com/pubsub/docs/admin#resource_names"> resource
1318-
// name rules</a>. Format is `projects/{project}/snapshots/{snap}`.
1325+
// must specify a name. See the [resource name
1326+
// rules](https://cloud.google.com/pubsub/docs/admin#resource_names). Format
1327+
// is `projects/{project}/snapshots/{snap}`.
13191328
string name = 1 [
13201329
(google.api.field_behavior) = REQUIRED,
13211330
(google.api.resource_reference) = { type: "pubsub.googleapis.com/Snapshot" }
@@ -1337,8 +1346,8 @@ message CreateSnapshotRequest {
13371346
}
13381347
];
13391348

1340-
// See <a href="https://cloud.google.com/pubsub/docs/labels"> Creating and
1341-
// managing labels</a>.
1349+
// See [Creating and managing
1350+
// labels](https://cloud.google.com/pubsub/docs/labels).
13421351
map<string, string> labels = 3;
13431352
}
13441353

‎protos/google/pubsub/v1/schema.proto‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -320,17 +320,17 @@ message DeleteSchemaRevisionRequest {
320320
// Required. The name of the schema revision to be deleted, with a revision ID
321321
// explicitly included.
322322
//
323-
// Example: projects/123/schemas/my-schema@c7cfa2a8
323+
// Example: `projects/123/schemas/my-schema@c7cfa2a8`
324324
string name = 1 [
325325
(google.api.field_behavior) = REQUIRED,
326326
(google.api.resource_reference) = { type: "pubsub.googleapis.com/Schema" }
327327
];
328328

329-
// Required. The revision ID to roll back to.
330-
// It must be a revision of the same schema.
331-
//
332-
// Example: c7cfa2a8
333-
string revision_id = 2 [(google.api.field_behavior) = REQUIRED];
329+
// Optional. This field is deprecated and should not be used for specifying
330+
// the revision ID. The revision ID should be specified via the `name`
331+
// parameter.
332+
string revision_id = 2
333+
[deprecated = true, (google.api.field_behavior) = OPTIONAL];
334334
}
335335

336336
// Request for the `DeleteSchema` method.

‎protos/protos.d.ts‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)