This repository was archived by the owner on Feb 15, 2026. It is now read-only.
refactor: removed async module dependency#120
Merged
JustinBeckwith merged 10 commits intogoogleapis:masterfrom Dec 21, 2018
Merged
refactor: removed async module dependency#120JustinBeckwith merged 10 commits intogoogleapis:masterfrom
JustinBeckwith merged 10 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
suggested changes
Nov 30, 2018
| strip: 1, | ||
| }, | ||
| next); | ||
| await extract( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| file.filename.indexOf('test') === -1); | ||
| }, | ||
| }, | ||
| () => {}); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| require('child_process').exec('rm -rf google', next); | ||
| }, | ||
| async function main() { | ||
| await require('child_process').exec('rm -rf google'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vijay-qlogic
force-pushed
the
rmv-async-module
branch
from
0f24838 to
ff3e7d7
Compare
JustinBeckwith
suggested changes
Nov 30, 2018
vijay-qlogic
force-pushed
the
rmv-async-module
branch
from
100e418 to
b5c9ef4
Compare
vijay-qlogic
force-pushed
the
rmv-async-module
branch
from
b5c9ef4 to
e4b0e0e
Compare
vijay-qlogic
force-pushed
the
rmv-async-module
branch
from
e4b0e0e to
4851daf
Compare
JustinBeckwith
changed the title
JustinBeckwith
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2883 partially for nodejs-proto-files (it's a good idea to open an issue first for discussion)