Skip to content
This repository was archived by the owner on Feb 15, 2026. It is now read-only.

refactor: use walkdir instead of globby#109

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:dobby
Nov 9, 2018
Merged

refactor: use walkdir instead of globby#109
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:dobby

Conversation

@JustinBeckwith
Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith commented Nov 9, 2018

Should have a ~120ms reduction in module load time.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
ofrobots
ofrobots approved these changes Nov 9, 2018
View reviewed changes
Copy link
Copy Markdown

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hopefully a follow-on can return a Promise of files rather than doing sync work. Who uses this feature anyway? Is the caching actually worth it?

@JustinBeckwith
Copy link
Copy Markdown
Contributor Author

JustinBeckwith commented Nov 9, 2018

I have no idea my friend. I don't have a good handle on what this library does vs gax. I will however follow up with an async version after this all propagates without incident. It's very core, so I'm scared to change a ton at once.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 9, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9a23d42). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage          ?   91.54%           
=========================================
  Files             ?        6           
  Lines             ?      201           
  Branches          ?        6           
=========================================
  Hits              ?      184           
  Misses            ?       17           
  Partials          ?        0
Impacted Files Coverage Δ
src/load.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a23d42...e168a1e. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7849ea3 into googleapis:master Nov 9, 2018
@hashim21223445 hashim21223445 mentioned this pull request Jul 28, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

2 more reviewers

@ofrobots ofrobots ofrobots approved these changes

@kjin kjin kjin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JustinBeckwith @codecov-io @ofrobots @kjin @googlebot