Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

chore: migrate to Trampoline V2#200

Closed
tmatsuo wants to merge 2 commits intogoogleapis:masterfrom
tmatsuo:trampoline-v2
Closed

chore: migrate to Trampoline V2#200
tmatsuo wants to merge 2 commits intogoogleapis:masterfrom
tmatsuo:trampoline-v2

Conversation

@tmatsuo
Copy link
Copy Markdown

@tmatsuo tmatsuo commented Sep 18, 2020

It will allow you to run the builds locally. For example, here is the
command for running the presubmit system test:

TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/node:12-user \
    TRAMPOLINE_BUILD_FILE=.kokoro/system-test.sh \
    SECRET_MANAGER_KEYS="npm_publish_token" \
    .kokoro/trampoline_v2.sh

Note: the current presubmit system test(.kokoro/presubmit/node12/system-test.cfg)
doesn't utilize any secrets.

It will allow you to run the builds locally. For example, here is the
command for running the presubmit system test:

```sh
TRAMPOLINE_IMAGE=gcr.io/cloud-devrel-kokoro-resources/node:12-user \
    TRAMPOLINE_BUILD_FILE=.kokoro/system-test.sh \
    SECRET_MANAGER_KEYS="npm_publish_token" \
    .kokoro/trampoline_v2.sh
```

Note: [the current presubmit system test](.kokoro/presubmit/node12/system-test.cfg)
doesn't utilize any secrets.
@tmatsuo tmatsuo requested review from a team and bcoe September 18, 2020 17:15
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 18, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files           5        5           
  Lines         523      523           
  Branches       29       29           
=======================================
  Hits          477      477           
  Misses         45       45           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d81a77...bad0ec8. Read the comment docs.

@tmatsuo
Copy link
Copy Markdown
Author

tmatsuo commented Sep 18, 2020

@bcoe Do you know what is Summary Check for ci/kokoro: Samples test? It seems it's a required check.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@bcoe
Copy link
Copy Markdown

bcoe commented Sep 21, 2020

@tmatsuo, @sofisl has been working on an experiment with GitHub actions that would allow us to make Sample/System tests optional for some types of PRs. Phishing Protection happened to be where we're testing this too.

@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@bcoe bcoe added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 21, 2020
@bcoe
Copy link
Copy Markdown

bcoe commented Sep 21, 2020

this is looking good, I'd like to generate it from your open PR on syntool though before merging 😄

@bcoe
Copy link
Copy Markdown

bcoe commented Sep 22, 2020

closing in favor of:

#202

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants