Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

fix: query should be on the list of extra args#365

Merged
alvarowolfx merged 3 commits intogoogleapis:mainfrom
alvarowolfx:fix-pass-query-extra-args
May 23, 2024
Merged

fix: query should be on the list of extra args#365
alvarowolfx merged 3 commits intogoogleapis:mainfrom
alvarowolfx:fix-pass-query-extra-args

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

The fix on #361 actually missed passing the query within the list of extra args, as on methods returning more than two arguments, the query is suppose to be on the list.

Example with BigQuery:

const [rows, q, response] = await bigqueryClient.query(sqlQuery, options)
// rows is the list of items accumulated with rows from all paginated calls
// q is initial Query
// response is the last call Response

@alvarowolfx alvarowolfx requested review from a team, ddelgrosso1 and feywind May 22, 2024 20:04
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label May 22, 2024
@alvarowolfx alvarowolfx added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: xs Pull request size is extra small. labels May 22, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label May 22, 2024
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 22, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants