feat: add getDefaultMetadataForTracing#388
Merged
kjin merged 3 commits intogoogleapis:masterfrom Sep 19, 2019
Merged
Conversation
googlebot
added
the
cla: yes
soldair
approved these changes
Sep 12, 2019
| const enableThunkAgent = !!( | ||
| agent && | ||
| agent.getCurrentContextId && | ||
| agent.getWriterProjectId |
Contributor
There was a problem hiding this comment.
this feels weird to me because it establishes some kind of peer dependency on a particular trace-agent version
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 92.07% 94.26% +2.18%
==========================================
Files 4 5 +1
Lines 101 122 +21
Branches 26 30 +4
==========================================
+ Hits 93 115 +22
Misses 4 4
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
@googleapis/node-team I've updated this PR to include the test. PTAL |
DominicKramer
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287
Looking for API feedback before I write tests.cc/ @googleapis/node-team