Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: enable custom json fields truncation for bunyan#732

Merged
cindy-peng merged 3 commits intomainfrom
cindy/truncate-json
Dec 8, 2023
Merged

feat: enable custom json fields truncation for bunyan#732
cindy-peng merged 3 commits intomainfrom
cindy/truncate-json

Conversation

@cindy-peng
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #682 🦕

Expose the ability to provide customized list of entries to be truncated to be consistent with the behavior in nodejs-logging. The list will be prepended to default existing list in nodejs-logging, and custom-defined fields will be truncated first.

@cindy-peng cindy-peng requested review from a team December 6, 2023 19:43
@cindy-peng cindy-peng self-assigned this Dec 6, 2023
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: logging Issues related to the googleapis/nodejs-logging-bunyan API. labels Dec 6, 2023
@cindy-peng cindy-peng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2023
@cindy-peng cindy-peng added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2023
@cindy-peng cindy-peng changed the title feat: enable custom json fields truncation feat: enable custom json fields truncation for bunyan Dec 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 7, 2023
@cindy-peng cindy-peng merged commit eb6fa66 into main Dec 8, 2023
@cindy-peng cindy-peng deleted the cindy/truncate-json branch December 8, 2023 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose jsonFieldsToTruncate

3 participants