Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: Fix rest links with the correct gRPC links used by library.#724

Merged
cindy-peng merged 3 commits intomainfrom
cindy/update-document
Nov 10, 2023
Merged

fix: Fix rest links with the correct gRPC links used by library.#724
cindy-peng merged 3 commits intomainfrom
cindy/update-document

Conversation

@cindy-peng
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #685 🦕
Updating google apis links since library uses the gRPC / Protobuf transport. This has been causing some confusions when there is type/format difference regarding the same property between Rest and gRPC.

@cindy-peng cindy-peng requested review from a team November 8, 2023 19:56
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Nov 8, 2023
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Nov 8, 2023
@cindy-peng cindy-peng merged commit 555c33e into main Nov 10, 2023
@cindy-peng cindy-peng deleted the cindy/update-document branch November 10, 2023 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

redirectToStdout: httpRequest.latency should be a string and not an object

3 participants