This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Conversation
product-auto-label
Bot
added
the
api: logging
losalex
reviewed
Aug 11, 2022
Contributor
losalex
left a comment
losalex
left a comment
There was a problem hiding this comment.
System test still fails with "error TS2307: Cannot find module './types/core' or its corresponding type declarations.". I wonder if we really need to update cp-cli - it seems that this change requires extra dependency, correct?
Contributor
Author
|
@losalex, this is an attempt at updating this dependency: #598 I'm not sure how to fix it, it seems like this ugprade is buggy: sindresorhus/cpy-cli#35 (there are more as well). I haven't had the chance to come back and look at this yet, if you do have cycles to upgrade it correctly I'd greatly appreciate it! |
product-auto-label
Bot
added
the
stale: old
sofisl
changed the title
losalex
approved these changes
Sep 13, 2022
Contributor
losalex
left a comment
losalex
left a comment
There was a problem hiding this comment.
Thanks for fixing this - much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.