Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: Update dependency @google-cloud/logging from 9.0.0 to 9.8.0#597

Merged
losalex merged 19 commits intomainfrom
losalex/fix-595
Mar 2, 2022
Merged

fix: Update dependency @google-cloud/logging from 9.0.0 to 9.8.0#597
losalex merged 19 commits intomainfrom
losalex/fix-595

Conversation

@losalex
Copy link
Copy Markdown
Contributor

@losalex losalex commented Mar 1, 2022

This is a fix to expose a default callback from Options used by LoggingBunyan so it would be propagated to Log constructor from @google-cloud/logging npm package. Also, update @google-cloud/logging dependency to 9.6.9.

Fixes #595 and #530 🦕

@losalex losalex requested review from a team March 1, 2022 00:31
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Mar 1, 2022
@product-auto-label product-auto-label Bot added the api: logging Issues related to the googleapis/nodejs-logging-bunyan API. label Mar 1, 2022
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 1, 2022
Copy link
Copy Markdown
Contributor

@arbrown arbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording fixes I missed last time

Comment thread .readme-partials.yml Outdated
Comment thread README.md Outdated
Comment thread .readme-partials.yml Outdated
@generated-files-bot
Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@losalex losalex assigned losalex and unassigned minherz Mar 1, 2022
Copy link
Copy Markdown

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, have added minor remarks.

Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread .readme-partials.yml Outdated
Comment thread src/middleware/express.ts Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: logging Issues related to the googleapis/nodejs-logging-bunyan API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants