Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: auto-detect service context#290

Merged
ofrobots merged 1 commit intomasterfrom
fix-135
Apr 15, 2019
Merged

feat: auto-detect service context#290
ofrobots merged 1 commit intomasterfrom
fix-135

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

@ofrobots ofrobots commented Apr 5, 2019

When running on GCP environments, automatically detect service context
so that error reporting can correctly pick up errors.

Fixes: #135

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2019
@ofrobots ofrobots added needs work This is a pull request that needs a little love. semver: minor A new feature was added. No breaking changes. labels Apr 10, 2019
When running on GCP environments, automatically detect service context
so that error reporting can correctly pick up errors.

Fixes: #135
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2019

Codecov Report

Merging #290 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #290      +/-   ##
========================================
+ Coverage   94.87%    95%   +0.12%     
========================================
  Files           2      2              
  Lines          78     80       +2     
  Branches        8      8              
========================================
+ Hits           74     76       +2     
  Misses          4      4
Impacted Files Coverage Δ
src/index.ts 96.72% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fce54...3b85595. Read the comment docs.

@ofrobots ofrobots requested a review from DominicKramer April 10, 2019 22:08
@ofrobots ofrobots removed the needs work This is a pull request that needs a little love. label Apr 10, 2019
@ofrobots
Copy link
Copy Markdown
Contributor Author

@DominicKramer PTAL.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 12, 2019
@ofrobots ofrobots merged commit 595a4db into master Apr 15, 2019
@ofrobots ofrobots deleted the fix-135 branch April 15, 2019 23:15
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement. semver: minor A new feature was added. No breaking changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-detect serviceContext.service on GCP

4 participants