Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: add missing dep on google-auth-library#278

Merged
ofrobots merged 1 commit intomasterfrom
fix-277
Mar 14, 2019
Merged

fix: add missing dep on google-auth-library#278
ofrobots merged 1 commit intomasterfrom
fix-277

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

We use this at runtime.

Fixes: #277

We use this at runtime.

Fixes: #277
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
@ofrobots ofrobots requested a review from DominicKramer March 14, 2019 21:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 14, 2019

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files           2        2           
  Lines          78       78           
  Branches        8        8           
=======================================
  Hits           74       74           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be1baba...fec9187. Read the comment docs.

@soldair soldair self-requested a review March 14, 2019 21:33
Copy link
Copy Markdown

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. reaching out to transitive dependencies is not a good idea even if it may reduce install size

@ofrobots ofrobots merged commit a89e73c into master Mar 14, 2019
@ofrobots ofrobots deleted the fix-277 branch March 14, 2019 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants