This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Conversation
googlebot
added
the
cla: yes
We promote a bunyan record.labels property to the LogEntry.labels property. This enables label based filtering to work auto-magically. However, this can be problematic when the labels are not type correct as per the logging proto requirements - specifically, the labels values have to be strings. Restrict the automatic promotion to happen only in the cases when know that the labels are well-formatted. Fixes: #265
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 91.78% 94.87% +3.09%
==========================================
Files 2 2
Lines 73 78 +5
Branches 6 8 +2
==========================================
+ Hits 67 74 +7
+ Misses 6 4 -2
Continue to review full report at Codecov.
|
DominicKramer
approved these changes
Feb 21, 2019
Contributor
DominicKramer
left a comment
DominicKramer
left a comment
There was a problem hiding this comment.
LGTM once tests pass.
Contributor
Author
|
System tests had failed with |
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
/cc @JustinBeckwith could we get the error reporting quota increased for the system test project? I added a few patches which meant that the tests ran a few times, probably pushing us over the quota. It would be good if we were not too close to the edge. |
Contributor
|
Was this a logging quota or error reporting API quota? |
Contributor
Author
|
Error reporting. |
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We promote a bunyan record.labels property to the LogEntry.labels
property. This enables label based filtering to work auto-magically.
However, this can be problematic when the labels are not type correct
as per the logging proto requirements - specifically, the labels values
have to be strings.
Restrict the automatic promotion to happen only in the cases when
know that the labels are well-formatted.
Fixes: #265