This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Conversation
googlebot
added
the
cla: yes
| assert.strictEqual(passedEmitRequestLog, undefined); | ||
| }); | ||
| }); | ||
| [GCPEnv.APP_ENGINE, GCPEnv.CLOUD_FUNCTIONS].forEach(env => { |
Contributor
There was a problem hiding this comment.
So not directly related to this PR - but I typically prefer to just copy the code for tests like this. Debugging a failure is hard because the stack trace becomes a guess, and things like .only and .skip become harder.
JustinBeckwith
approved these changes
Feb 12, 2019
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 2 2
Lines 73 73
Branches 6 6
=======================================
Hits 67 67
Misses 6 6Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.