This repository was archived by the owner on Feb 7, 2026. It is now read-only.
chore: the sample tests complete correctly#232
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Dec 12, 2018
Merged
chore: the sample tests complete correctly#232JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
Conversation
The samples tests start an express server that is used during the test. Previously, this server was not properly shutdown causing the tests to timeout. Now the server is correctly shutdown after the express tests to ensure the tests complete correctly.
googlebot
added
the
cla: yes
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Even this may not work. I suggest pulling this in: https://www.npmjs.com/package/server-destroy
JustinBeckwith
approved these changes
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samples tests start an express server that is used during the
test. Previously, this server was not properly shutdown causing
the tests to timeout. Now the server is correctly shutdown after
the express tests to ensure the tests complete correctly.