This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix(middleware): use bunyan log.child#163
Merged
ofrobots merged 3 commits intogoogleapis:masterfrom Sep 28, 2018
Merged
Conversation
It turns out bunyan provides built-in support for Child loggers to insert scope specific keys into the log metadata. This means that we don't have to hand-roll an approximation to the bunyan API. There should be no functional changes for JS users. TS users will see the types change. Given that this support is clearly marked as experimental in the docs, we are not going to deem these as semver major changes.
ghost
assigned
googlebot
added
the
cla: yes
soldair
approved these changes
Sep 26, 2018
soldair
left a comment
soldair
left a comment
There was a problem hiding this comment.
lgtm. these error_reporting system tests are a little flakey
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
ofrobots
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out bunyan provides built-in support for Child loggers to
insert scope specific keys into the log metadata. This means that
we don't have to hand-roll an approximation to the bunyan API.
There should be no functional changes for JS users. TS users will see
the types change. Given that this support is clearly marked as
experimental in the docs, we are not going to deem these as semver
major changes.