Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

chore: fix stream example in README#134

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
DominicKramer:doc/fix-README-stream-usage
Aug 27, 2018
Merged

chore: fix stream example in README#134
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
DominicKramer:doc/fix-README-stream-usage

Conversation

@DominicKramer
Copy link
Copy Markdown
Contributor

@DominicKramer DominicKramer commented Aug 23, 2018

The stream method expects one argument, which is the log level.
However, the example in the README didn't show that this argument
was required.

@DominicKramer DominicKramer requested a review from a team August 23, 2018 18:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2018
@ghost ghost assigned DominicKramer Aug 23, 2018
@ghost ghost assigned JustinBeckwith Aug 27, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2018

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files           3        3           
  Lines         343      343           
  Branches       21       21           
=======================================
  Hits          291      291           
  Misses         52       52
Impacted Files Coverage Δ
src/middleware/express.ts 7.31% <0%> (ø) ⬆️
src/index.ts 94.52% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a81ee...9b38839. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7132e8b into googleapis:master Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants