fix: Unique-ify getEntries resourceNames #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 396 399 +3
=====================================
+ Hits 396 399 +3
Continue to review full report at Codecov.
|
Merged
callmehiphop
approved these changes
Mar 19, 2018
ghost
removed
the
cla: yes
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #91
I caught this while investigating #91. When we auto-paginate using the
nextQueryobject built by GAPIC, we constantly push the project ID resource to thereqOpts.resourceNamesargument. So for each run, we end up with with a new, duplicate entry ofprojects/my-project-id.This flattens them, as well as localizes the project ID returned by the auth client, so we can still flatten the array when the user is using ADC.