This repository was archived by the owner on Mar 11, 2026. It is now read-only.
refactor: drop dependency on common-grpc#606
Merged
JustinBeckwith merged 5 commits intomasterfrom Oct 17, 2019
Merged
Conversation
googlebot
added
the
cla: yes
JustinBeckwith
requested review from
alexander-fenster,
bcoe and
stephenplusplus
bcoe
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
bcoe
approved these changes
Oct 16, 2019
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
This looks reasonable to me, I like the approach of vending the parts of common-grpc that we're using.
I'm concerned about the failing system tests, because they look like they might be real, I'll kick off tests a couple times and see if we just had a blip.
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 97.09% 94.81% -2.29%
==========================================
Files 10 11 +1
Lines 447 501 +54
Branches 59 74 +15
==========================================
+ Hits 434 475 +41
- Misses 0 12 +12
- Partials 13 14 +1
Continue to review full report at Codecov.
|
| @@ -0,0 +1,217 @@ | |||
| /*! | |||
Contributor
There was a problem hiding this comment.
We should copy over the test suite for these files from common-grpc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.