Repository navigation
feat: support apiEndpoint override - #501
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 10 10
Lines 431 431
Branches 55 55
=======================================
Hits 419 419
Partials 12 12
Continue to review full report at Codecov.
|
| "devDependencies": { | ||
| "@google-cloud/bigquery": "^4.0.0", | ||
| "@google-cloud/nodejs-repo-tools": "^3.0.0", | ||
| "@google-cloud/nodejs-repo-tools": "^3.3.0", |
There was a problem hiding this comment.
there's an open PR for the repo-metadata.json, at which point we can just get rid of this dependency all together.
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
This looks good to me. A thought, it might be nice to stand up a proxy internally that we could use to write integration tests for the new apiEndpoint functionality; it would be nice to see the setting chained all the way through.
We could at least test manually once all these are setup by running a local proxy.
|
+1 to that - for now I'm just getting the plumbing hooked up |
|
|
This is going to pass the property onto the underlying gapic generated layer, so no real work is needed :)