This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix(types): improve types for LogEntry#448
Merged
ofrobots merged 2 commits intogoogleapis:masterfrom Apr 10, 2019
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
I believe this is semver patch as the types have relaxed. An argument can be made that we should restrict the types to accept only |
Contributor
|
Looks like you need an |
Contributor
Author
|
Ah, yup. Done. |
callmehiphop
approved these changes
Apr 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 14 14
Lines 681 681
Branches 34 34
=======================================
Hits 622 622
Misses 41 41
Partials 18 18
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #442
@bcoe I know you wanted to look at this bug too. I had some spare cycles so I went ahead and implemented this. LMK if you have another fix already prepared, or have something more holistic about the types we expose across all of the library. We can close this one in that case.