Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

refactor (typescript): noImplilcitAny#408

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
AVaksman:types
Mar 1, 2019
Merged

refactor (typescript): noImplilcitAny#408
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
AVaksman:types

Conversation

@AVaksman
Copy link
Copy Markdown
Contributor

@AVaksman AVaksman commented Mar 1, 2019

Fixes #264

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 1, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2019

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          14       14           
  Lines         631      631           
  Branches       34       34           
=======================================
  Hits          571      571           
  Misses         42       42           
  Partials       18       18
Impacted Files Coverage Δ
src/index.ts 99.45% <100%> (ø) ⬆️
src/sink.ts 96.42% <100%> (-0.13%) ⬇️
src/log.ts 80.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f881ec...828d823. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 1, 2019

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          14       14           
  Lines         631      631           
  Branches       34       34           
=======================================
  Hits          571      571           
  Misses         42       42           
  Partials       18       18
Impacted Files Coverage Δ
src/index.ts 99.45% <100%> (ø) ⬆️
src/sink.ts 96.42% <100%> (-0.13%) ⬇️
src/log.ts 80.23% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f881ec...828d823. Read the comment docs.

Comment thread src/index.ts
import * as gax from 'google-gax';
import {ClientReadableStream} from 'grpc';
import * as is from 'is';
import * as request from 'request';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is types only... right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants