This repository was archived by the owner on Mar 11, 2026. It is now read-only.
fix: stop exporting express types publicly#376
Merged
ofrobots merged 3 commits intogoogleapis:masterfrom Feb 4, 2019
Merged
Conversation
We don't have a dependency on express. If we expose express types as part of our public, our dependent modules will need to have a dev dependency on @types/express. Otherwise they see their builds failing. Currently there is no way to express this dependency relationship to npm. Instead, let's not use express types. Ref: googleapis/nodejs-logging-bunyan#243
googlebot
added
the
cla: yes
JustinBeckwith
approved these changes
Feb 2, 2019
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
After all of that debate.... this is a much, much better approach 👏
Contributor
Author
|
This doesn't solve the problem generally. It just kicks the can down the road. |
Contributor
Author
|
@DominicKramer @JustinBeckwith do you have opinions on the semver-ness here? The APIs are supposed to be internal APIs between I deem this to be semver-patch. Let me know if you disagree. |
Contributor
|
Patch is fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have a dependency on express. If we expose express types
as part of our public, our dependent modules will need to have a dev
dependency on @types/express. Otherwise they see their builds failing.
Currently there is no way to express this dependency relationship to
npm.
Instead, let's not use express types.
Ref: googleapis/nodejs-logging-bunyan#243