This repository was archived by the owner on Mar 11, 2026. It is now read-only.
refactor(ts): generate logging types from proto#314
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Nov 12, 2018
Merged
refactor(ts): generate logging types from proto#314JustinBeckwith merged 2 commits intogoogleapis:masterfrom
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
The second step would be to check-in the generated |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 14 14
Lines 644 644
Branches 57 57
=======================================
Hits 594 594
Misses 36 36
Partials 14 14Continue to review full report at Codecov.
|
Contributor
Author
|
While we are here, we should also address https://github.com/googleapis/nodejs-logging/issues/133. |
Contributor
Author
|
Re: #133, I believe the dynamic proto/logging.js above. /cc @alexander-fenster
|
JustinBeckwith
approved these changes
Nov 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to hand-writing the type-definitions #309.