This repository was archived by the owner on Mar 11, 2026. It is now read-only.
refactor: go back to prettier, use generated gapic tests#308
Merged
JustinBeckwith merged 1 commit intogoogleapis:masterfrom Nov 7, 2018
JustinBeckwith:resynth
Merged
refactor: go back to prettier, use generated gapic tests#308JustinBeckwith merged 1 commit intogoogleapis:masterfrom JustinBeckwith:resynth
JustinBeckwith merged 1 commit intogoogleapis:masterfrom
JustinBeckwith:resynth
Conversation
googlebot
added
the
cla: yes
ofrobots
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this commit solves a few problems, mostly around the generation process.
test/gapic-v2.jsover to TypeScript. However... this is a generated file. I instead changed the build to just copy this file as-is over to build/test.