This repository was archived by the owner on Mar 11, 2026. It is now read-only.
chore(build): use the latest npm on windows for tests#304
Merged
jkwlui merged 2 commits intogoogleapis:masterfrom Nov 7, 2018
JustinBeckwith:lolwindows
Merged
chore(build): use the latest npm on windows for tests#304jkwlui merged 2 commits intogoogleapis:masterfrom JustinBeckwith:lolwindows
jkwlui merged 2 commits intogoogleapis:masterfrom
JustinBeckwith:lolwindows
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
@kinwa91 for whatever reason, this repo is seeing some weird failures with |
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage ? 92.19%
=========================================
Files ? 14
Lines ? 641
Branches ? 57
=========================================
Hits ? 591
Misses ? 36
Partials ? 14Continue to review full report at Codecov.
|
Contributor
|
We should probably apply the change across all repos if we think the current version is bad - I can @google/repo it. |
jkwlui
approved these changes
Nov 7, 2018
Contributor
Author
|
I mean I don't know if what I'm doing here makes a difference 😆 but it seemed to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.