Skip to content
This repository was archived by the owner on Mar 11, 2026. It is now read-only.

refactor(metadata): use async/await#295

Merged
ofrobots merged 3 commits intogoogleapis:masterfrom
ofrobots:metadata-refactor
Oct 31, 2018
Merged

refactor(metadata): use async/await#295
ofrobots merged 3 commits intogoogleapis:masterfrom
ofrobots:metadata-refactor

Conversation

@ofrobots
Copy link
Copy Markdown
Contributor

Get rid of unnecessary class and use async/await.

Get rid of unnecessary class and use async/await.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2018
Comment thread package.json
Comment thread src/log.ts
Comment thread src/log.ts
Comment thread test/metadata.ts Outdated
Comment thread test/metadata.ts Outdated
Comment thread src/log.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c41db2f). Click here to learn what that means.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #295   +/-   ##
=========================================
  Coverage          ?   92.19%           
=========================================
  Files             ?       14           
  Lines             ?      641           
  Branches          ?       57           
=========================================
  Hits              ?      591           
  Misses            ?       36           
  Partials          ?       14
Impacted Files Coverage Δ
src/metadata.ts 100% <100%> (ø)
src/log.ts 98.52% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41db2f...83e6cfe. Read the comment docs.

@ofrobots ofrobots merged commit 08e3e9c into googleapis:master Oct 31, 2018
@ofrobots ofrobots deleted the metadata-refactor branch October 31, 2018 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants